[mythtv-commits] Ticket #8564: Inserting a new cut point alters existing cut points

MythTV mythtv at cvs.mythtv.org
Sun Jun 20 13:44:55 UTC 2010


#8564: Inserting a new cut point alters existing cut points
-------------------------------+--------------------------------------------
 Reporter:  jrlagrone@…        |       Owner:  markk     
     Type:  defect             |      Status:  accepted  
 Priority:  minor              |   Milestone:  unknown   
Component:  MythTV - General   |     Version:  Trunk Head
 Severity:  low                |     Mlocked:  0         
-------------------------------+--------------------------------------------

Comment(by Jim Stichnoth <stichnot@…>):

 There is a logic error in DeleteMap::CleanMap() :

 {{{
 Index: libs/libmythtv/deletemap.cpp
 ===================================================================
 --- libs/libmythtv/deletemap.cpp        (revision 25143)
 +++ libs/libmythtv/deletemap.cpp        (working copy)
 @@ -387,7 +387,7 @@
              uint64_t thisframe = it.key();
              if (lasttype == thistype)
              {
 -                Delete(thistype == MARK_CUT_END ? thisframe :
 +                Delete(thistype == MARK_CUT_START ? thisframe :
                                                    (uint64_t)lastframe);
                  clear = false;
                  break;
 }}}

 I believe this fixes jrlagrone's examples.

 However, the aggressive calling of CleanMap() after every edit is a change
 from the old behavior.  If I want to move the boundary of an existing cut
 region to the current point, I press Select, then Up or Down, and Select
 again, but once in a while the first Select is received as two separate
 Selects, which ends up deleting an adjacent cut mark without the
 opportunity to undo.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/8564#comment:3>
MythTV <http://www.mythtv.org/>
MythTV


More information about the mythtv-commits mailing list