[mythtv-commits] Ticket #8124: Themestring.h updates in r23643 appears to be wrong

[MythTV]

#8124: Themestring.h updates in r23643 appears to be wrong
----------------------------------------+-----------------------------------
 Reporter:  Kenni Lund <kenni@…>        |       Owner:  ijr    
     Type:  defect                      |      Status:  new    
 Priority:  critical                    |   Milestone:  0.23   
Component:  MythTV - General            |     Version:  unknown
 Severity:  medium                      |     Mlocked:  0      
----------------------------------------+-----------------------------------

Comment(by Nicolas Riendeau <knight@…>):

 Hi,

 The script committed in changeset 23642 actually goes back one directory
 too many and processes the entire MythTV structure including the plugins
 (which is the reason why you see stuff from MythWeather MythGames,
 etc...).

 As for the XML files used by the US NWS parser they should not, as I had
 told you in a (private) email a few months ago, be included. The
 themestringtool processes these like they were themes because they are XML
 files and contain <description> fields.

 By the way, it should be noted that the script in changeset 23642 should
 not be run in a directory structure where you have uncommitted (or not yet
 put in a .diff file) stuff because it removes files to get them out of the
 way and the easiest way to get rid of the the US NWS XML files would be to
 remove them as well before running the themestringtool so it would  remove
 even more stuff than what is currently removed.

 It might also be a good idea to make a temporary symlink to the other
 theme directories (that were added in changeset 23649) so that it would
 make them at the same time and avoid the duplicates created by running
 them in two pass and merging them after.

 Have a nice day,

 Nick

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/8124#comment:1>
MythTV <http://www.mythtv.org/>
MythTV