[mythtv-commits] Ticket #9725: [PATCH] Frontend network control does not always return a prompt

[MythTV]

#9725: [PATCH] Frontend network control does not always return a prompt
----------------------------------------------+----------------------------
 Reporter:  Gregory Moyer <moyerg@…>          |           Type:  Patch -
   Status:  new                               |  Bug Fix
Milestone:  unknown                           |       Priority:  minor
  Version:  Trunk Head                        |      Component:  MythTV -
 Keywords:  frontend network control          |  General
                                              |       Severity:  medium
                                              |  Ticket locked:  0
----------------------------------------------+----------------------------
 When using the frontend network control, if a command does not generate
 any result, nothing is sent back to the client. This means that no prompt
 is sent back to the client as well.

 The problem is in mythtv/programs/mythfrontend/networkcontrol.cpp in
 NetworkControl::processNetworkControlCommand(NetworkCommand *nc). If a
 command does not return any result (e.g. 'query recordings' when there are
 no recordings), the if check will resolve to 'false' and nothing
 (including the prompt) is sent back.

 Frontend version log, logs of example sessions using netcat before and
 after the patch, and a patch removing the if condition will be attached. I
 have only tested this patch lightly, but it seems to work well.

 If removing this if condition is not acceptable, the other route is to
 make sure all commands return something. In the case of 'query recordings'
 something like 'No recordings found.' could be returned. This seems like a
 more difficult and error prone way to fix this though.

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/9725>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center