[mythtv-commits] Ticket #9746: Inconsistent default / help text for Storage Group disk scheduler

[MythTV]

#9746: Inconsistent default / help text for Storage Group disk scheduler
---------------------------------------+------------------------
     Reporter:  rkulagow               |      Owner:  danielk
         Type:  Patch - Bug Fix        |     Status:  new
     Priority:  minor                  |  Milestone:  unknown
    Component:  MythTV - Mythtv-setup  |    Version:  Trunk Head
     Severity:  low                    |   Keywords:
Ticket locked:  0                      |
---------------------------------------+------------------------
 One of the following two patches should be applied.  Although we specify
 that Balanced Free Space is recommended for most users in the help text,
 the default value inserted into the database during the schema update
 isn't Balanced Free Space:

 {{{
 rkulagow at master:~/mythtv$ git diff
 diff --git a/mythtv/libs/libmythtv/dbcheck.cpp
 b/mythtv/libs/libmythtv/dbcheck.cpp
 index e0d17c5..e31028c 100644
 --- a/mythtv/libs/libmythtv/dbcheck.cpp
 +++ b/mythtv/libs/libmythtv/dbcheck.cpp
 @@ -4865,7 +4865,7 @@ NULL
      if (dbver == "1241")
      {
         const char *updates[] = {
 -"INSERT INTO settings ( value, data, hostname ) VALUES (
 'StorageScheduler', 'Combination', NULL );",
 +"INSERT INTO settings ( value, data, hostname ) VALUES (
 'StorageScheduler', 'BalancedFreeSpace', NULL );",
  NULL
  };
          if (!performActualUpdate(updates, "1242", dbver))
 diff --git a/mythtv/programs/mythbackend/config_backend_general.xml
 b/mythtv/programs/mythbackend/config_backend_general.xml
 index b8b5882..ebeb22b 100644
 --- a/mythtv/programs/mythbackend/config_backend_general.xml
 +++ b/mythtv/programs/mythbackend/config_backend_general.xml
 @@ -177,11 +177,11 @@
             range_min="4700" range_max="94000" step="4700" />
  -->
          <setting
 -           value="StorageScheduler" default_data="BalancedFreeSpace"
 +           value="StorageScheduler" default_data="Combination"
             setting_type="global" label="Storage Group Disk Scheduler"
             help_text="This setting controls how the Storage Group
                        scheduling code will balance new recordings across
 -                      directories. 'Balanced Free Space' is the
 recommended
 +                      directories. 'Combination' is the recommended
                        method for most users."
             data_type="select">
            <option display="Balanced Free Space" data="BalancedFreeSpace"
 />
 }}}

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/9746>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center