[mythtv-commits] Ticket #9542: [patch] player slider show incorrect values (livetv)

[MythTV]

#9542: [patch] player slider show incorrect values (livetv)
-------------------------------------------------+-------------------------
 Reporter:  Jiri Fojtasek <jiri.fojtasek@…>      |          Owner:  janne
     Type:  Patch - Bug Fix                      |         Status:  new
 Priority:  trivial                              |      Milestone:  unknown
Component:  MythTV - Video Playback              |        Version:  Trunk
 Severity:  low                                  |  Head
 Keywords:                                       |     Resolution:
                                                 |  Ticket locked:  0
-------------------------------------------------+-------------------------

Comment (by Jiri Fojtasek <jiri.fojtasek@…>):

 Replying to [comment:3 tralph]:
 > Jiri, there is a *very* good reason that we use PTS for the display time
 since it properly handles variable frame rate and frame repeats properly.
 Using a frame count is not accurate in many situations and I will not
 revert back to using such a flawed method. If pre-recorded works properly
 then your patch is not the best solution to this problem. So what's wrong
 with "pts normalization in avformat decoder."?

 In case of variable framerate you are right(i asked for fixme). So the
 solution will be reset decoder time base when switching/jumping to next
 program in livetv chain. Here is what exactly happen:

 Program 1 length 5 minutes
 secondsplayed counting from 0 to 300 slider show secondsplayed/playbacklen
 (all is OK)

 switchtoprogram()

 Program 2 length 10 minutes
 secondsplayed counting from 300 to 900 slider show only
 playbacklen/playbacklen (wrong)

 switchtoprogram()

 Program 3 length 10 minutes
 secondsplayed counting from 901 to 1500 slider show only
 playbacklen/playbacklen (wrong)

 When i hit pause slider still counting playbacklen/playbacklen

 When i jump back to Program 2 slider stop and show only
 playbacklen/playbacklen of Program 2

 Conclusion, since frames played is not usefull as time base, we need
 adjust time base to count from zero during jumptoprogram/switchtoprogram.
 Ill rework the patch to adjust disp_timecode to program playback
 boundaries.

 Jiri

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/9542#comment:4>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center