[mythtv-commits] mythtv/fixes/0.24 commit: ad1543aef by Mark Kendall (mark-kendall)

MythTV noreply at mythtv.org
Tue Feb 15 01:52:07 UTC 2011


      Author:  Mark Kendall <mkendall at mythtv.org>
 Change Date:  2011-02-14T17:33:02-08:00
   Push Date:  2011/02/14 17:52:03 -0800
  Repository:  mythtv
      Branch:  fixes/0.24
New Revision:  ad1543aefe287de8706c2e8365208b973427f5dd
   Changeset:  https://github.com/MythTV/mythtv/commit/ad1543aef

Log:

Refactor 'eof' handling in the decoder and player classes.

This moves all eof 'ownership' into the decoder which is then queried by
the player as needed. AvFormatDecoder is extended to reset the picture
buffer eof flag to zero if we are clearing the eof state.

This fixes livetv program transitions where the decoder has already
decided it has hit the end of the file before we switch to the next
program and as a result stops returning frames.

My only concern here is the extra locking now required inside the GetEof
method in MythPlayer. The current plan of action is however to ensure
the decoder locking is 'industrial strength' (Hint: it currently isn't)
before looking at how to minimise the locking required in the main
playback loop.
(cherry picked from commit 679b668e3669a38bd08e93aa1f210ad11da0984e)

Modified:

   mythtv/libs/libmythtv/avformatdecoder.cpp
   mythtv/libs/libmythtv/avformatdecoder.h
   mythtv/libs/libmythtv/decoderbase.cpp
   mythtv/libs/libmythtv/decoderbase.h
   mythtv/libs/libmythtv/mythcommflagplayer.cpp
   mythtv/libs/libmythtv/mythplayer.cpp
   mythtv/libs/libmythtv/mythplayer.h
   mythtv/libs/libmythtv/nuppeldecoder.cpp



More information about the mythtv-commits mailing list