[mythtv-commits] Ticket #9586: Commit d149a01 (Changed MPUBLIC define) breaks Windows build

[MythTV]

#9586: Commit d149a01 (Changed MPUBLIC define) breaks Windows build
-------------------------------------------------+-------------------------
 Reporter:  Lawrence Rust <lvr@…>                |          Owner:  beirdo
     Type:  Bug Report                           |         Status:  closed
 Priority:  trivial                              |      Milestone:  0.25
Component:  MythTV - General                     |        Version:  Trunk
 Severity:  medium                               |  Head
 Keywords:  MPUBLIC Windows                      |     Resolution:  Fixed
                                                 |  Ticket locked:  0
-------------------------------------------------+-------------------------

Comment (by Gavin Hurlbut):

 Another run at getting rid of symbol issues

 Change version.cpp -> libs/libmythbase/version.h, which we then include in
 mythversion.h.  Also convert from extern const char * -> #define
 constants.
 This will remove all of the symbols.  However, it comes at the cost of a
 slightly slower re-compile as every file that uses the constants will need
 recompiling.  If we wanted to get around that, we can use functions in
 libmythbase as the access points, such that only one file needs a
 recompile,
 and it is buried in a library, but still anything using said library will
 need
 relinking.

 Can't win, really.  Refs #9586
  Changeset: 70a157f96c5644510700057cb9437395188c67d9

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/9586#comment:32>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center