[mythtv-commits] Ticket #9520: [PATCH] MediaMonitor::GetMedias - search for multile media types
MythTV
noreply at mythtv.org
Sat Jan 29 12:23:59 UTC 2011
#9520: [PATCH] MediaMonitor::GetMedias - search for multile media types
-------------------------------------------------+-------------------------
Reporter: Lawrence Rust <lvr@…> | Owner: paulh
Type: Patch - Feature | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - General | Version: Trunk
Severity: medium | Head
Keywords: | Resolution:
| Ticket locked: 0
-------------------------------------------------+-------------------------
Comment (by Lawrence Rust <lvr@…>):
As it stands, MythGallery asks for MEDIATYPE_DATA which in the case of a
disk containing gifs and jpegs and scanned statistically results in no
match. If MythGallery were to request MEDIATYPE_MGALLERY then a disk
without gifs or jpegs would not be matched even though the Qt QImageReader
might be able to read them. QtImageReader uses system plugins to decode
images so you need to ask at runtime what formats are supported. So it's
pragmatic to call GetMedias with a bit mask of types.
I'm not suggesting a re-definition of MediaType as a bit mask. That would
break a lot of code and weaken type checking. Just change the parameter
type of GetMedias.
I don't think it's necessary for MediaTypeString to return a list because
all the other APIs take an enum MediaType i.e. a single type.
Furthermore, it would unnecessarily complicate the code for no obvious
benefit.
--
Ticket URL: <http://code.mythtv.org/trac/ticket/9520#comment:3>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
More information about the mythtv-commits
mailing list