[mythtv-commits] Ticket #9931: patch: mythmetadatalookup --refresh-all-artwork can update the wrong recording

[MythTV]

#9931: patch: mythmetadatalookup --refresh-all-artwork can update the wrong
recording
-----------------------------------------------+---------------------------
 Reporter:  Doug Haber <doug@…>                |           Type:  Patch -
   Status:  new                                |  Bug Fix
Milestone:  unknown                            |       Priority:  minor
  Version:  Trunk Head                         |      Component:  MythTV -
 Keywords:                                     |  General
                                               |       Severity:  medium
                                               |  Ticket locked:  0
-----------------------------------------------+---------------------------
 Hey All,[[BR]]
 [[BR]]
 mythmetatdatalookup --refresh-all-artwork calls
 "RemoteGetAllScheduledRecordings(recordingList)" to get a list of
 recording rules.  This list comes back as a list of ProgramInfo objects
 even though on the backend it's really RecordingInfo objects.  This
 doesn't matter much, however, the backend has some logic to set the
 starttime/endtime to be the current date at midnight if the recording type
 isn't Single,Don't,Override,Timeslot or Weekly.  [[BR]]
 [[BR]]
 So if you're unlucky (like I was) and you have multiple recording rules on
 channel 123 that aren't one of the above types (e.g. Record All) and you
 happened to record something today at midnight on the same channel, then
 when pginfo->SaveInetref() is called it will overwrite your recording's
 inetref with the one from the recording rule.  [[BR]]
 [[BR]]
 Even if you're not unlucky, it's still making unnecessary DB calls to
 update the recorded table when it shouldn't since it's inspecting a
 recording rule and not a recording .  The attached patch makes sure that
 we only make the Save() calls if the programinfo is likely to actually be
 a program info, that is, it has start & end time that aren't equal.
 [[BR]]
 [[BR]]
 Thanks! [[BR]]

 Doug

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/9931>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center