[mythtv-commits] Ticket #9729: mythtranscode with --honorcutlist do not work

[MythTV]

#9729: mythtranscode with --honorcutlist do not work
------------------------------------+----------------------------
 Reporter:  zeloise@…               |          Owner:  mdean
     Type:  Bug Report - Crash      |         Status:  closed
 Priority:  minor                   |      Milestone:  0.25
Component:  MythTV - Mythtranscode  |        Version:  Trunk Head
 Severity:  medium                  |     Resolution:  fixed
 Keywords:                          |  Ticket locked:  0
------------------------------------+----------------------------
Changes (by Github):

 * status:  assigned => closed
 * resolution:   => fixed
 * milestone:  unknown => 0.25


Comment:

 Prevent transcode failures due to false "updated cut list".

 The recording editor's undo/redo functionality modifies the cut list, so
 when the transcoder sets the cut list and we save the undo information,
 the DB was updated to show that the cut list had changed with a
 MARK_UPDATED_CUT.  When the transcoder noticed the MARK_UPDATED_CUT
 (which only happened on long-running transcodes--so wouldn't necessarily
 happen on lossless transcodes or very fast systems), mythtranscode
 exited with a REENCODE_CUTLIST_CHANGE error, thinking someone else had
 changed the cut list.

 This patch changes the delete map so that SetMap() does not save an undo
 point; therefore, it prevents the MARK_UPDATED_CUT.  Since the UI does
 not allow direct access to SetMap(), this shouldn't have any visible
 effect--other than to allow transcoding to work properly.

 This approach is a temporary fix until I've had time to finish a patch
 which reorganizes the delete map code to separate the UI code from the
 data/logic code.

 Thanks for the report, zeloise, and for the additional information,
 Otto.

 Fixes #9729.
  Branch:    master
  Changeset: e4be111e54b77ddc606e6072fa2f1f5fbddc4a0a

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/9729#comment:6>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center