[mythtv-commits] Ticket #10111: EIA-608 caption timing broken

[MythTV]

#10111: EIA-608 caption timing broken
------------------------------------------------+--------------------------
 Reporter:  Jim Stichnoth <stichnot@…>          |          Owner:  danielk
     Type:  Bug Report - General                |         Status:  assigned
 Priority:  minor                               |      Milestone:  0.25
Component:  MythTV - General                    |        Version:  Trunk
 Severity:  medium                              |  Head
 Keywords:                                      |     Resolution:
                                                |  Ticket locked:  0
------------------------------------------------+--------------------------

Comment (by Jim Stichnoth <stichnot@…>):

 I think the timing problem was actually introduced in
 4fe1522fc8fd957f76fa3d82f0b9cecf7ad7748c.  SubtitleScreen::Pulse() now
 always calls DisplayAVSubtitles() which has the side effect of resetting
 m_safeArea, and then SubtitleScreen::DisplayTextSubtitles() and
 SubtitleScreen::DisplayCC608Subtitles() (and other places in
 subtitlescreen.cpp) continually find that m_safeArea has changed and
 execute some reinitialization path.  This is especially noticeable in the
 log when SRT subtitles are displayed.

 If I comment out the call to DisplayAVSubtitles(), the timing problem goes
 away, though the frame dropping problem remains.

 I tried reverting the cc608decoder.cpp portions of
 d526385aa4c1466b064e9544cdb663f357007e35 but didn't see any difference in
 my test recording.

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/10111#comment:2>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center