[mythtv-commits] Ticket #10071: Bugfixes to mythburn.py

[MythTV]

#10071: Bugfixes to mythburn.py
----------------------------------+-----------------------------
 Reporter:  t.brackertz@…         |          Owner:  paulh
     Type:  Patch - Bug Fix       |         Status:  new
 Priority:  minor                 |      Milestone:  0.25
Component:  Plugin - MythArchive  |        Version:  Unspecified
 Severity:  medium                |     Resolution:
 Keywords:                        |  Ticket locked:  0
----------------------------------+-----------------------------

Comment (by paulh):

 Thanks to everyone who is working on this.

 I am the only dev who maintains MythArchive all or most of the others want
 it removed :( which would be ashame but since I rarely use it myself I
 can't justify spending long periods of time on it.

 At this stage I'm not bothered whether it's a single patch or several so
 long as I don't have to spend a lot of time fixing things or working out
 why something was done the way it was.

 I switched to always using ac3 audio because when I tested it around
 Christmas the internal Myth player couldn't handle the switching from one
 format to the other properly. Actually to be compliant with the ntsc dvd
 spec all the audio should be ac3 anyway. Changing the behavior should be
 as simple as changing encodetoac3 = True to False at the top of the
 script.

 Just looking at the last patch added remind me of why it has sat here
 rotting. When I see stuff like
 {{{
 isopath="/mnt/f10store/myth/arctmp/isos/mythburn.iso" # is not stored in
 the db
 }}}

 something that clearly doesn't belong in the patch. It just adds to the
 time required to review it because it means having to spend time figuring
 out why was it added and and can I just remove it etc.

 Something else that worried me when I first looked at the patch was the
 switch to the latest version of ProjectX. Generally if all the major
 distributions are shipping with that version then that is fine but if not
 then that can cause problems. If possible we like to wait at least 6
 months after all the major distros start shipping new versions to give
 time for people to upgrade. It needs someone to do a little research to
 find out what version most distros are shipping with these days.

 Other things to watch out for is fixing things so it works well for one
 locale or set of uses but breaks things for others. One common one is
 forgetting that not everyones recordings are in a TS container some are in
 PES. ProjectX for example behaves differently depending on the format you
 pass it.

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/10071#comment:9>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center