[mythtv-commits] mythtv/master commit: 128c9df8d by Daniel Kristjansson (daniel-kristjansson)

[MythTV]

      Author:  Daniel Kristjansson <danielk at cuymedia.net>
 Change Date:  2012-02-07T06:35:26-08:00
   Push Date:  2012/02/07 06:40:47 -0800
  Repository:  mythtv
      Branch:  master
New Revision:  128c9df8dbcdb8231613f92cc03aa21e4f25b47d
   Changeset:  https://github.com/MythTV/mythtv/commit/128c9df8d

Log:

Make Scheduler::GetAllScheduled() thread-safe.

Commit [fd582899] made a private function public so I went to check
if it was safe to do so. It wasn't but this was easily missed
because the public getAllScheduled() was already calling that
function without any locking for the recordTable variable access.

This adds locking to findAllScheduledPrograms() and then renames
getAllScheduled(QStringList&) to GetAllScheduled(QStringList&) and
findAllScheduledPrograms(RecList&) to GetAllScheduled(RecList&) for
naming consistency with the GetAllPending(*) methods. I also made
both functions const since they don't modify the state of the
Scheduled class.

Modified:

   mythtv/programs/mythbackend/mainserver.cpp
   mythtv/programs/mythbackend/scheduler.cpp
   mythtv/programs/mythbackend/scheduler.h
   mythtv/programs/mythbackend/services/dvr.cpp