[mythtv-commits] Ticket #10319: suspected problem in schedduleeditor

[MythTV]

#10319: suspected problem in schedduleeditor
----------------------------------+-----------------------------
 Reporter:  markspieth            |          Owner:
     Type:  Bug Report - General  |         Status:  new
 Priority:  minor                 |      Milestone:  unknown
Component:  MythTV - General      |        Version:  Unspecified
 Severity:  medium                |     Resolution:
 Keywords:                        |  Ticket locked:  0
----------------------------------+-----------------------------
Description changed by markspieth:

Old description:

> this just looks wrong for the parameters and previous functionality
>
> should be
>
> {{{
> --- a/mythtv/programs/mythfrontend/scheduleeditor.cpp
> +++ b/mythtv/programs/mythfrontend/scheduleeditor.cpp
> @@ -558,8 +558,8 @@ void SchedOptEditor::Load()
>      for (uint i = 0; i < inputids.size(); ++i)
>      {
>          new MythUIButtonListItem(m_inputList, tr("Prefer input %1")
> -
> .arg(CardUtil::GetDisplayName(inputids[i]))
> -                                 .arg(inputids[i]));
> +
> .arg(CardUtil::GetDisplayName(inputids[i])),
> +                                 inputids[i]);
>      }
>
>      m_inputList->SetValueByData(m_recordingRule->m_prefInput);
> }}}
>
> inline due to its simplicity. If Im wrong just disregard.

New description:

 this just looks wrong for the parameters and previous functionality

 should be

 {{{
 --- a/mythtv/programs/mythfrontend/scheduleeditor.cpp
 +++ b/mythtv/programs/mythfrontend/scheduleeditor.cpp
 @@ -566,8 +566,8 @@ void SchedOptEditor::Load()
      for (uint i = 0; i < inputids.size(); ++i)
      {
          new MythUIButtonListItem(m_inputList, tr("Prefer input %1")
 -
 .arg(CardUtil::GetDisplayName(inputids[i]))
 -                                 .arg(inputids[i]));
 +
 .arg(CardUtil::GetDisplayName(inputids[i])),
 +                                 inputids[i]);
      }

      m_inputList->SetValueByData(m_recordingRule->m_prefInput);
 }}}

 inline due to its simplicity. If Im wrong just disregard.

--

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/10319#comment:1>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center