[mythtv-commits] Ticket #10234: New Metadata screens break schedule recording on oldish themes
MythTV
noreply at mythtv.org
Tue Jan 3 06:04:16 UTC 2012
#10234: New Metadata screens break schedule recording on oldish themes
---------------------------------------------+----------------------------
Reporter: mythtv.hook@… | Owner: stuartm
Type: Bug Report - General | Status: closed
Priority: critical | Milestone: unknown
Component: MythTV - User Interface Library | Version: Trunk Head
Severity: medium | Resolution: Invalid
Keywords: | Ticket locked: 0
---------------------------------------------+----------------------------
Comment (by mythtv.hook@…):
That response raises a number of other issues:
- http://www.mythtv.org/wiki/Schedule-
ui.xml#The_.22scheduleeditor.22_window states that the metadata option is
not required (which is backward compatible with all existing 0.24 themes)
- The version of Graphite (25.1) and other themes available in the theme
downloader are not up to date (I tested them before originally submitting
this ticket, and again just now)
- The theme downloader lists themes which do not have support for
metadata
Heres the patch to scheduleeditor.cpp which makes metadata optional and as
such allow all existing themes to be backward compatible:
{{{
diff --git a/mythtv/programs/mythfrontend/scheduleeditor.cpp
b/mythtv/programs/mythfrontend/scheduleeditor.cpp
index 07aa81a..0cbbad7 100644
--- a/mythtv/programs/mythfrontend/scheduleeditor.cpp
+++ b/mythtv/programs/mythfrontend/scheduleeditor.cpp
@@ -127,7 +127,7 @@ bool ScheduleEditor::Create()
UIUtilE::Assign(this, m_postProcButton, "postprocessing", &err);
UIUtilE::Assign(this, m_schedInfoButton, "schedinfo", &err);
UIUtilE::Assign(this, m_previewButton, "preview", &err);
- UIUtilE::Assign(this, m_metadataButton, "metadata", &err);
+ UIUtilW::Assign(this, m_metadataButton, "metadata");
UIUtilE::Assign(this, m_cancelButton, "cancel", &err);
UIUtilE::Assign(this, m_saveButton, "save", &err);
}}}
As I mentioned in the original ticket, I like the ability to choose
metadata for recordings, but as it is the only change ive noticed that
breaks existing themes it should be optional (or provided in another way)
--
Ticket URL: <http://code.mythtv.org/trac/ticket/10234#comment:2>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
More information about the mythtv-commits
mailing list