[mythtv-commits] Ticket #10248: Cannot delete recording if file is missing
MythTV
noreply at mythtv.org
Mon Jan 9 20:43:38 UTC 2012
#10248: Cannot delete recording if file is missing
----------------------------------+----------------------------
Reporter: stuartm | Owner: paul-h
Type: Bug Report - General | Status: new
Priority: major | Milestone: 0.25
Component: MythTV - General | Version: Trunk Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------+----------------------------
Description changed by stuartm:
Old description:
> Following [02bbb8ab] which converted PBB to use MythMenu it's no longer
> possible to delete a recording if the file is missing. The reason is that
> m_popupMenu is not null when the delete failed event (DELETE_FAILURES)
> arrives and all that happens is the warning "PlaybackBox: Delete failures
> not handled due to pre-existing popup."
>
> We don't actually delete or NULL the MythMenu object until reaching the
> destructor of MythDialogBox. Since QObject deletions occur last in the
> event loop, after queued signals/events are processed this will always be
> too late. Added to that the fade effect means that several event loop
> iterations can pass before the popup is even deleted which just increases
> the likelihood that m_popupMenu will not be NULL when checked or reused.
New description:
Following [02bbb8ab] which converted PBB to use MythMenu it's no longer
possible to delete a recording if the file is missing. The reason is that
m_popupMenu is not null when the delete failed event (DELETE_FAILURES)
arrives and all that happens is the warning "PlaybackBox: Delete failures
not handled due to pre-existing popup."
We don't actually delete or NULL the MythMenu object pointer until
reaching the destructor of MythDialogBox. Since QObject deletions occur
last in the event loop, after queued signals/events are processed this
will always be too late. Added to that the fade effect means that several
event loop iterations can pass before the popup is even deleted which just
increases the likelihood that m_popupMenu will not be NULL when checked or
reused.
--
--
Ticket URL: <http://code.mythtv.org/trac/ticket/10248#comment:1>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
More information about the mythtv-commits
mailing list