[mythtv-commits] Ticket #10280: Quick manual channel selection in tv browse mode doesn't work if there is no 'browse all channels' option activated
MythTV
noreply at mythtv.org
Mon Jan 23 15:15:37 UTC 2012
#10280: Quick manual channel selection in tv browse mode doesn't work if there is
no 'browse all channels' option activated
-------------------------------+----------------------------------
Reporter: dluzin@… | Type: Patch - Bug Fix
Status: new | Priority: minor
Milestone: unknown | Component: MythTV - General
Version: Master Head | Severity: medium
Keywords: | Ticket locked: 0
-------------------------------+----------------------------------
The problem occurs if you are in LiveTV channel browse mode, have
"Setup"->"Video"->"Playback OSD"->"Browse all cahnnels" off,
"Setup"->"Video"->"Playback OSD"->"Always use browse mode in Live TV" on,
have more than one card per source and trying to enter channel number
manually. After you finish entering the channel number it just disappeares
from the screen without putting entered channel to browse OSD.
There are actually two problems resides in two places:
1. tv_play.cpp, function TV::CommitQueuedInput, line around 12374,
ctx->playingInfo->GetSourceID() always returns '0' because
playingInfo.sourceid is not set (I was'nt able to find where it should be
set, so my solution is to get sourceid by a different way)
2. tvbrowsehelper.cpp, function TVBrowseHelper::TVBrowseHelper, around
line 52 - during querying all channels list for cardid and sourceid
comparision 'GROUP BY "channum, callsign"' drops all result rows with same
channel numbers leaving just the first one (in my case one source has 4
cardid's, so each channel in this source has to have 4 cardids), so I just
added "cardid" as additional GROUP BY parameter.
So I'm attaching a small patch that solves above mentioned problems and
allows to use 'quick channel selection in browse mode'.
Best regards,
Dennis
--
Ticket URL: <http://code.mythtv.org/trac/ticket/10280>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
More information about the mythtv-commits
mailing list