[mythtv-commits] Ticket #10283: CEA-708 caption font is sometimes excessively large
MythTV
noreply at mythtv.org
Tue Jan 24 23:58:42 UTC 2012
#10283: CEA-708 caption font is sometimes excessively large
-------------------------------------------------+-------------------------
Reporter: Clayton Smith <argilo@…> | Owner: danielk
Type: Patch - Bug Fix | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - ATSC | Version: Master Head
Severity: medium | Keywords: cea-708
Ticket locked: 0 |
-------------------------------------------------+-------------------------
When watching an ATSC recording, if closed captions are turned on (via the
"T" key, for example) before any CEA-708 captions have occurred in the
stream, then captions will be displayed with an excessively large font
size, such that the letters overlap and extend off the screen. A good way
to reproduce this is to press "T" while the "Playback starting..." screen
is displayed, before the recording begins playing.
This occurs because the DisplayCC608Subtitles function in
subtitlescreen.cpp is called before the DisplayCC708Subtitles function is
called. DisplayCC608Subtitles updates m_safeArea, and then
DisplayCC708Subtitles doesn't realize this has happened and so doesn't
bother to update m_708fontSizes. This patch modifies
DisplayCC708Subtitles such that it always sets m_708fontSizes on its first
invocation.
I have tested it with the PBS test material (
http://ncamftp.wgbh.org/DTV/CEA%20test%20material/) and recorded programs
from various local ATSC stations. As far as I can tell, the problem is
fixed and no new problems have appeared.
--
Ticket URL: <http://code.mythtv.org/trac/ticket/10283>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
More information about the mythtv-commits
mailing list