[mythtv-commits] Ticket #10286: Weather world map for mythweather

MythTV noreply at mythtv.org
Sun Jan 29 12:59:02 UTC 2012


#10286: Weather world map for mythweather
----------------------------------+-----------------------------
 Reporter:  joachim@…             |          Owner:  beirdo
     Type:  Patch - Feature       |         Status:  new
 Priority:  minor                 |      Milestone:  unknown
Component:  Plugin - MythWeather  |        Version:  Master Head
 Severity:  medium                |     Resolution:
 Keywords:                        |  Ticket locked:  0
----------------------------------+-----------------------------

Comment (by stuartm):

 A copy of the image should be assigned to MythUIImage since MythUIImage
 takes ownership and can/will modify it including scaling/cropping which
 would break later calls to addToMap(). It may even delete it before the
 screen is closed. You would need to call SetImage() after drawing the
 icons to the map image.

 To guard against leaks or crashes, MythImage is reference counted, UpRef()
 should be called after it's creation and DownRef() when it should be
 deleted - in this case the screen's destructor.

 setCurrentTemperatur should be setCurrentTemperature

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/10286#comment:6>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center


More information about the mythtv-commits mailing list