[mythtv-commits] mythtv/master commit: 5e13d41a8 by Michael T. Dean (sphery)

MythTV noreply at mythtv.org
Tue Jan 31 00:30:04 UTC 2012


      Author:  Michael T. Dean <mdean at mythtv.org>
 Change Date:  2012-01-30T16:26:59-08:00
   Push Date:  2012/01/30 16:29:49 -0800
  Repository:  mythtv
      Branch:  master
New Revision:  5e13d41a8eea7faa030a07c9d19ce5efce5dc925
   Changeset:  https://github.com/MythTV/mythtv/commit/5e13d41a8

Log:

Remove support for GNOME screensaver.

The GNOME developers broke the "legacy" inhibit support (inhibit via
gnome-screensaver-command) a couple years ago and seem to have no
intention of ever fixing it, instead focusing on forcing every single
media player application in the world (or other applications needing to
provide hints to the screensaver) to add D-Bus-based inhibit requests
using their GNOME-specific D-Bus API (see
https://bugzilla.gnome.org/show_bug.cgi?id=579430 ).  (Of course, this
approach would then mean all of those applications must also implement
code to add D-Bus-based inhibit requests using the KDE-specific D-Bus
API to support users running KDE screensaver, and ...  And, as a point
of note, KDE has taken the same approach and has the same expectation of
applications.)

Therefore, this patch removes the GNOME screensaver legacy inhibit
support so that users of GNOME screensaver, like users of KDE
screensaver, will fall back to getting DPMS-based screensaver control.
If GNOME screensaver, like KDE screensaver, actually takes the hint when
the DPMS state is changed, this should allow users to once again run
GNOME screensaver (which has been unsupported since GNOME broke
gnome-screensaver-command --poke) without the screensaver activating
during playback.  If GNOME screensaver doesn't take a clue from the DPMS
state, GNOME screensaver should be fixed.

This change does not purport to provide support for users who run GNOME
screensaver.  This simply removes the code that calls a broken program
that GNOME has said they will not fix.

Modified:

   mythtv/libs/libmythui/screensaver-x11.cpp



More information about the mythtv-commits mailing list