[mythtv-commits] Ticket #10214: 88-Key Piano Visualization for MythMusic

MythTV noreply at mythtv.org
Thu Mar 8 06:00:26 UTC 2012


#10214: 88-Key Piano Visualization for MythMusic
------------------------------------------+-----------------------------
 Reporter:  MythTV-Trac@…                 |          Owner:  paulh
     Type:  Patch - Feature               |         Status:  closed
 Priority:  minor                         |      Milestone:  0.25
Component:  Plugin - MythMusic            |        Version:  Master Head
 Severity:  medium                        |     Resolution:  fixed
 Keywords:  visualization, new            |  Ticket locked:  0
------------------------------------------+-----------------------------

Comment (by jyavenard):

 I had trouble compiling this on my machine.

 Upon investigation, the culprit is in the Piano class, and the two
 <vector> members: rects and magnitude.

 In Piano::draw, you call the method data() on the <vector>

 std::vector do not have a data() method, only QVector do.


 So either the type of rects and magnitude should be changed to QVector, or
 replace the data() call with something like: &rects[0] (or use the
 .begin() iterator).

 I'll be modifying the code accordingly

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/10214#comment:2>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center


More information about the mythtv-commits mailing list