[mythtv-commits] Ticket #10396: Periodical, short audio artifacts in one the channels when upmixing to 5.1

MythTV noreply at mythtv.org
Thu Mar 15 10:33:17 UTC 2012


#10396: Periodical, short audio artifacts in one the channels when upmixing to 5.1
------------------------------------------+-----------------------------
 Reporter:  blazej.lewcio@…               |          Owner:  jyavenard
     Type:  Bug Report - General          |         Status:  closed
 Priority:  minor                         |      Milestone:  0.25
Component:  MythTV - Audio Output         |        Version:  Unspecified
 Severity:  medium                        |     Resolution:  fixed
 Keywords:  upmixing                      |  Ticket locked:  0
------------------------------------------+-----------------------------
Changes (by Github):

 * status:  infoneeded_new => closed
 * resolution:   => fixed
 * milestone:  unknown => 0.25


Comment:

 Fully clear the audio ringbuffer when using AC3 re-encoder

 When the audio buffer was reset, we could find ourselves in a situation
 where a full audio frame may not have fitted at the end of the ring
 buffer. This would have resulted in channels being shifted for a short
 period of time when we rollled over in the buffer.
 This situation could only happen when using the AC3 encoder as we change
 the size of an audio frame half-way through.

 When the AC3 re-encoder is in use, we now fully clear the audio buffer and
 fill it with zero. That way at worse we hear silence instead of crap and
 not have to worry about threading issues.

 Add some extra logging that will clearly show an error should this
 condition occurs again. Will help troubleshoot should any issues remain.

 Additionally, from Mark Spieth, fully reset any audio processing unit that
 could have cached old audio.

 Should fix #10396
 Thanks Mark for actually spotting what went wrong
  Branch:    master
  Changeset: f8d2de08e982bd646d0a3e430ec8799f7494f8f8

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/10396#comment:36>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center


More information about the mythtv-commits mailing list