[mythtv-commits] Ticket #10514: logcleanup.py has an invalid syntax error

[MythTV]

#10514: logcleanup.py has an invalid syntax error
------------------------------------+-----------------------------
 Reporter:  christopher.j.reeves@…  |          Owner:
     Type:  Bug Report - General    |         Status:  closed
 Priority:  minor                   |      Milestone:  unknown
Component:  Packaging               |        Version:  Master Head
 Severity:  medium                  |     Resolution:  Won't Fix
 Keywords:  logcleanup.py           |  Ticket locked:  0
------------------------------------+-----------------------------
Changes (by wagnerrp):

 * status:  new => closed
 * resolution:   => Won't Fix


Comment:

 I'm closing this one due to it not making any sense. The switch to use
 '''print''' as a function rather than a directive is fine, but you left
 out the all important '''`from __future__ import print_function`''' which
 allows it to continue to work on Python 2.6+. You didn't take care of the
 issue of the old '''`__cmp__`''' method being no longer being used in
 Python 3.x, meaning this script will delete log files in some arbitrary
 and completely incorrect order. The script still used '''!OptionParser''',
 which is deprecated and should not be used for Python 3.x. One commit
 appeared to do nothing but move parts of the code from 4-space to 2-space
 soft tabbing.

 I've made the necessary changes to the script to allow it to be run
 directly under Python 2.6+ or Python 3.x, and will be committing such in
 the next day or so.

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/10514#comment:2>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center