[mythtv-commits] Ticket #10402: Alternative implementation of CC608zoom; Implement DVD subtitle zoom

[MythTV]

#10402: Alternative implementation of CC608zoom; Implement DVD subtitle zoom
-------------------------------+-----------------------------
 Reporter:  ggervasio@…        |          Owner:  stichnot
     Type:  Patch - Feature    |         Status:  accepted
 Priority:  minor              |      Milestone:  0.26
Component:  MythTV - Captions  |        Version:  Master Head
 Severity:  medium             |     Resolution:
 Keywords:                     |  Ticket locked:  0
-------------------------------+-----------------------------

Comment (by stichnot):

 Gregorio,

 I have a couple of questions about the AV subtitle patch.  First, this
 portion of the patch:

 {{{
 @@ -269,7 +272,8 @@ void SubtitleScreen::DisplayAVSubtitles(void)
                  int right  = rect->x + rect->w;
                  int bottom = rect->y + rect->h;
                  if (subs->fixPosition || (currentFrame->height < bottom)
 ||
 -                   (currentFrame->width  < right))
 +                   (currentFrame->width  < right) ||
 +                   !display.width() || !display.height())
                  {
                      int sd_height = 576;
                      if ((m_player->GetFrameRate() > 26.0f) && bottom <=
 480)

 }}}
 doesn't seem to have anything to do with zooming, right?  Do you have a
 sample that displays incorrectly (irrespective of zooming) when width or
 height are 0?

 Second, comments in the patch indicate that if a subtitle spans the center
 line, it gets split into the top half and the bottom half, and each half
 is drawn separately.  It seems that that would work reasonably for a zoom
 greater than 100%, but that a zoom less than 100% would lead to a possibly
 large gap between the two halves.  Is this right?  Do you have a sample
 with a subtitle spanning the center line?

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/10402#comment:3>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center