[mythtv-commits] Ticket #10402: Alternative implementation of CC608zoom; Implement DVD subtitle zoom

[MythTV]

#10402: Alternative implementation of CC608zoom; Implement DVD subtitle zoom
-------------------------------+-----------------------------
 Reporter:  ggervasio@…        |          Owner:  stichnot
     Type:  Patch - Feature    |         Status:  accepted
 Priority:  minor              |      Milestone:  0.26
Component:  MythTV - Captions  |        Version:  Master Head
 Severity:  medium             |     Resolution:
 Keywords:                     |  Ticket locked:  0
-------------------------------+-----------------------------

Comment (by ggervasio@…):

 1.  Sorry, I'm not exactly sure whether that check was only required with
 the zooming changes.  I do know that I had to add that check separately
 after the other changes were in place.  (I had been maintaining the other
 changes locally for >5 years and that check was only added a few months
 ago.)  Let me see if I can find a clip which triggers that code.  It might
 be difficult because much of my testing has been on rentals.

 2.  Yes, the patch intentionally tries to keep the center of the display
 clear when zoom is <100%.  The case I've seen where DVD subtitles span the
 center line is when there are subtitles at the top and bottom edges of the
 display, so it works well in that case -- the subtitles stay at the top
 and bottom instead of one side being "off".  I will see if I can find an
 example.

     However, as you say, it won't look good if the subtitles are supposed
 to be grouped in the center of the display.  I've seen this with the CC608
 patch (and I just live with it) but I don't think I've run into such a
 case with DVDs.  I think the bigger problem with subtitles in the center
 is that if the zoom is >100%, I think the patch may cause the two halves
 to overlap.  To be honest, I didn't consider that anyone would want to use
 zoom >100%.

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/10402#comment:4>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center