[mythtv-commits] Ticket #11141: Experimental commerciall flagging options D2 goes into finite loop on frame 0 taking 100% CPU

[MythTV]

#11141: Experimental commerciall flagging options D2 goes into finite loop on frame
0 taking 100% CPU
------------------------------------------------+--------------------------
 Reporter:  Wayne McDougall <waynemcdougall@…>  |          Owner:  stichnot
     Type:  Patch - Bug Fix                     |         Status:  accepted
 Priority:  minor                               |      Milestone:  0.26.1
Component:  MythTV - Mythcommflag               |        Version:  Master
 Severity:  medium                              |  Head
 Keywords:                                      |     Resolution:
                                                |  Ticket locked:  0
------------------------------------------------+--------------------------

Comment (by Wayne McDougall <waynemcdougall@…>):

 D2.patch does not handle the case where Logo detection wants to skip over
 100 frames at a time.

 The original code assumes that GetRawVideoFrame() will return a frame >=
 to the frame number requested - this is no longer true.

 D2_v2.patch fixes this and is significantly faster - previously it was
 seeking to every frame, even when sequential - now it only seeks when it
 needs to jump to a specified frame.

 While this patch will allow the code to work, I will note, as other
 developers have commented, that the detection code is both slow, and no
 better than the Classic Commercial detector code - my experience confirms
 those anecdotal comments.

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/11141#comment:4>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center