[mythtv-commits] Ticket #11411: fix mythcommflag segfaults in mpeg2_fast_decode_block_non_intra
MythTV
noreply at mythtv.org
Wed Feb 20 01:52:10 UTC 2013
#11411: fix mythcommflag segfaults in mpeg2_fast_decode_block_non_intra
-------------------------------------------------+-------------------------
Reporter: thomas-joiner | Owner: cpinkham
<thomas.b.joiner@…> | Status: new
Type: Patch - Bug Fix | Milestone: unknown
Priority: minor | Version: 0.26-fixes
Component: MythTV - Mythcommflag | Keywords:
Severity: high |
Ticket locked: 0 |
-------------------------------------------------+-------------------------
Patch is a pull request: https://github.com/MythTV/mythtv/pull/37
The segfault in ticket #10222 is still causing problems for me.
The problem in that issue was that AvFormatDecoder was adding the
CODEC_FLAG2_FAST flag. This causes unsafe functions to be used, causing a
segfault. The proper way to fix this would probably be to figure out how
to test for the "experimental speedups" flag, however I don't know the
codebase well enough for this.
I'm not sure that it is worth setting it up that way however, as I tested
how this would affect the speed of mythcommflag on one of my recordings.
The results (command used: time mythcommflag -f /path/to/file.mpg):
Before removing flag:
{{{
real 2m13.123s
user 2m16.713s
sys 0m3.502s
}}}
After removing flag:
{{{
real 2m13.021s
user 2m15.446s
sys 0m3.758s
}}}
--
Ticket URL: <http://code.mythtv.org/trac/ticket/11411>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
More information about the mythtv-commits
mailing list