[mythtv-commits] Ticket #11341: RemoteFile::Open() can leak MythSockets

[MythTV]

#11341: RemoteFile::Open() can leak MythSockets
------------------------------+--------------------------------------
 Reporter:  paulh <mythtv@…>  |           Type:  Bug Report - General
   Status:  new               |       Priority:  minor
Milestone:  unknown           |      Component:  MythTV - General
  Version:  Master Head       |       Severity:  medium
 Keywords:                    |  Ticket locked:  0
------------------------------+--------------------------------------
 RemoteFile::Open(void) doesn't check to see if it's sockets have already
 been opened so it's possible for some new sockets to be created without
 first closing and deleting the old ones.

 Things are made worse by the fact that the RemoteFile constructor will
 automatically call Open() if a url is passed to it.

 These are a few places where a RemoteFile is created with a url passed to
 it and later Open() is called :- There is one in MusicSGIODevice which is
 where I first spotted the problem while playing back tracks from the Music
 storage group. There is a couple in MetadataDownload readMXML() and
 readNFO().

 These all cause the Error: Not all threads were shut down properly: Thread
 MythSocketThread(-1) is still running warnings when exiting the FE.

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/11341>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center