[mythtv-commits] Ticket #11660: Patch to initialize Initialize member variables in MythRenderOpenGL ctor - fixes Coverity 700926 and 700927

MythTV noreply at mythtv.org
Thu Jul 11 14:36:53 UTC 2013


#11660: Patch to initialize Initialize member variables in MythRenderOpenGL ctor -
fixes Coverity 700926 and 700927
-------------------------------------------------+-------------------------
 Reporter:  Gary Buhrmaster <gary.buhrmaster@…>  |          Owner:
     Type:  Patch - Bug Fix                      |         Status:  new
 Priority:  minor                                |      Milestone:  unknown
Component:  MythTV - User Interface Library      |        Version:  Master
 Severity:  medium                               |  Head
 Keywords:                                       |     Resolution:
                                                 |  Ticket locked:  0
-------------------------------------------------+-------------------------

Comment (by Gary Buhrmaster <gary.buhrmaster@…>):

 Replying to [comment:1 natanojl]:
 > This introduces a small leak of m_lock unless
 MythRenderOpenGL::ResetVars() is removed from
 MythRenderOpenGL[12]::ResetVars(void).

 Good catch.  Thanks.  I had seen the "new" a month or so ago when I first
 reviewed a possible fix, and then completely forgot about it (and missed
 it) in this second pass.  I'll try to get a revised patch worked out when
 I have some time this weekend.  In case it takes me some time to get
 around to it, you should feel free to close this ticket (as
 "broken"/"wontfix") and I'll submit a new ticket with a new patch.

--
Ticket URL: <http://code.mythtv.org/trac/ticket/11660#comment:2>
MythTV <http://www.mythtv.org>
MythTV Media Center


More information about the mythtv-commits mailing list