[mythtv-commits] Ticket #11678: Video metadata downloads the least popular fanart from tmdb

MythTV noreply at mythtv.org
Sun Jul 14 16:01:44 UTC 2013


#11678: Video metadata downloads the least popular fanart from tmdb
----------------------------------+-----------------------------
 Reporter:  anonymous@…           |          Owner:  wagnerrp
     Type:  Bug Report - General  |         Status:  closed
 Priority:  minor                 |      Milestone:  0.26.1
Component:  MythTV - General      |        Version:  Unspecified
 Severity:  medium                |     Resolution:  fixed
 Keywords:                        |  Ticket locked:  0
----------------------------------+-----------------------------

Comment (by Raymond Wagner <rwagner@…>):

 In [changeset:"ce8f07005d607d1b6578e1085c796d0eafe490ce/mythtv"]:
 {{{
 #!CommitTicketReference repository="mythtv"
 revision="ce8f07005d607d1b6578e1085c796d0eafe490ce"
 Fix metadata fanart selection.

 When artwork is processed from metadata grabber results, the artwork is
 put into a QMultiMap, indexed based off the type. When pulling values
 back out of a QMultiMap, they are in reverse order from how they were
 inserted. Since the grabber is assumed to place the highest rated
 artwork at the top of the response list, it must be pulled back out of
 the bottom of the QMultiMap.

 Commit c3d64c80 made this change for all artwork types by fanart. Fanart
 had special handling, to allow it to select different artwork for each
 season of a television show. However, the logic used to select the
 artwork resulted in being indexed from the beginning of the list, rather
 than indexed from the back of the list, thus pulling the lowest rated
 artwork rather than the highest.

 Fixes #11678
 (cherry picked from commit da8ac305c3dbe955459a6a12e646b81109552836)
 }}}

--
Ticket URL: <http://code.mythtv.org/trac/ticket/11678#comment:3>
MythTV <http://www.mythtv.org>
MythTV Media Center


More information about the mythtv-commits mailing list