[mythtv-commits] mythtv branch master updated by cpinkham. v0.27-pre2-1578-g4c9dc6d

[Git Repo Owner]

The branch, master has been updated on the
mythtv repository by gitolite user cpinkham.
       via  4c9dc6d7eebe6853285efbe76a2f81ad80ebbc3c (commit)
      from  ba75244a7f7e412bdb100b7741eaa6a6f0e6649b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4c9dc6d7eebe6853285efbe76a2f81ad80ebbc3c
Author:    Chris Pinkham <cpinkham at mythtv.org> at Mon, 24 Jun 2013 12:00:33 -0700
Committer: Chris Pinkham <cpinkham at mythtv.org> at Mon, 24 Jun 2013 12:00:33 -0700
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=4c9dc6d7eebe6853285efbe76a2f81ad80ebbc3c

RemoteFile leak fix and simplification
RemoteFile::Open() would leak file descriptors if Open() was explicitly
called again after passing a url to the contructor which itself called
Open().

This commit does several things:

- Moves Open() private since RemoteFile users shouldn't need to Open()
- Moves Close() private since there's no need to Close() if you can't Open().
  Close() is already called in the destructor.
- Convert the remaining uses of Open() to isOpen() since the connection is
  already opened in all these cases.
- Remove a few Close() uses since they were were redundant since we already
  Close() in the destructor.
- Removes unused SetURL() functionality.  If you can't Open() or Close(),
  then you need to pass the URL in to the constructor so there's no need.
- Fixes the actual leak in Open() by checking to see if the sockets are
  already open.  Just in case....  Closes #11341.

NOTE: This does modify the binary ABI version number due to the remotefile.h
      changes, so make clean, etc..



-----------------------------------------------------------------------

Summary of changes:
 mythplugins/mythmusic/mythmusic/decoderhandler.cpp |    1 -
 mythtv/libs/libmythbase/mythversion.h              |    2 +-
 mythtv/libs/libmythbase/remotefile.cpp             |    3 +++
 mythtv/libs/libmythbase/remotefile.h               |    6 +++---
 mythtv/libs/libmythmetadata/metadatadownload.cpp   |    6 ++----
 5 files changed, 9 insertions(+), 9 deletions(-)

--