[mythtv-commits] Ticket #11612: Patch to check the return value from posix_fadvise in fileringbuffer.cpp - fixes coverity 746748 and 766747

MythTV noreply at mythtv.org
Wed Jun 26 18:44:25 UTC 2013


#11612: Patch to check the return value from posix_fadvise in fileringbuffer.cpp -
fixes coverity 746748 and 766747
-------------------------------------------------+-------------------------
 Reporter:  Gary Buhrmaster <gary.buhrmaster@…>  |          Owner:
     Type:  Patch - Bug Fix                      |         Status:  new
 Priority:  minor                                |      Milestone:  unknown
Component:  MythTV - General                     |        Version:  Master
 Severity:  medium                               |  Head
 Keywords:                                       |     Resolution:
                                                 |  Ticket locked:  0
-------------------------------------------------+-------------------------

Comment (by Gary Buhrmaster <gary.buhrmaster@…>):

 Since the only errors returned per the spec (which would only result in
 logs if running at the file debug level anyway) will occur with a
 programming error (bad fd, bad advise option specification), the logs
 would not be spammed (unless there is something else seriously broken in
 some new codes).  fadvise does not return an error if it simply decides to
 ignore the offset/sizes (it simple ignores the advise, and moves on), so
 logs would never be generated in those cases.

--
Ticket URL: <http://code.mythtv.org/trac/ticket/11612#comment:2>
MythTV <http://www.mythtv.org>
MythTV Media Center


More information about the mythtv-commits mailing list