[mythtv-commits] Ticket #12057: Improve legibility and display of CEA-608 captions.
MythTV
noreply at mythtv.org
Wed Feb 12 23:05:24 UTC 2014
#12057: Improve legibility and display of CEA-608 captions.
---------------------------------------+-------------------------
Reporter: faginbagin <mythtv@…> | Owner: stichnot
Type: Patch - Feature | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - Captions | Version: Unspecified
Severity: medium | Keywords:
Ticket locked: 0 |
---------------------------------------+-------------------------
Make sure 608 captions are centered on screen, while still confined to 90%
safe area, as long as zoom factor is not too extreme.
Use correct maximum columns (32) and rows (15) for geometry.
Compute a better font.pixelSize by making first guess, then adjusting
using QFontMetrics' height and lineSpacing to choose a font.pixelSize that
works for all but the most extreme fonts.
Eliminate use of fudge factors that caused a number of problems, such as:
* smaller than necessary font.pixelSize (if a user thinks it's too large,
subtitle zoom still works).
* Gaps between caption lines.
* Captions meant for row 14 appearing on row 15.
Make sure top rows are anchored to top of safe area and bottom rows are
anchored to bottom of safe area while eliminating unnecessary floating
point arithmetic.
More logging at verbosity vbi and log level debug have been added to gain
visibility into geometry calculations.
This patch will apply cleanly to master, but it was actually tested on
fixes/0.27 after the following files were checked out from master:
mythtv/libs/libmythtv/cc608decoder.cpp
mythtv/libs/libmythtv/cc708reader.cpp
mythtv/libs/libmythtv/cc708window.cpp
mythtv/libs/libmythtv/cc708window.h
mythtv/libs/libmythtv/mythccextractorplayer.cpp
mythtv/libs/libmythtv/subtitlescreen.cpp
mythtv/libs/libmythtv/subtitlescreen.h
It was also tested with the bug fix patches from tickets [[ticket:12051]]
and [[ticket:12056]]. However, all three patches should apply cleanly
independent of each other.
--
Ticket URL: <https://code.mythtv.org/trac/ticket/12057>
MythTV <http://www.mythtv.org>
MythTV Media Center
More information about the mythtv-commits
mailing list