[mythtv] Re: [PATCH] mono support
John Coiner
mythtv-dev@snowman.net
Mon, 18 Nov 2002 23:53:03 -0500
Jim,
It would be great to parameterize all of the player/recorder code in
terms of 'channels' and 'bytes_per_sample' etc. The option to use mono
would be pretty sweet for people with mono tuners, especially if they
don't have the world's fastest CPU.
I made some changes to the a/v sync code over the weekend, which are in
CVS now. The patch you posted will collide with them. Sorry about that.
It shouldn't be too hard to straighten out...
There are two changes now in cvs:
* A/V sync will account for audio sitting in the sound card's capture
buffer. I forgot this before, and it was introducing some error. Whereas
now there is absolutely zero error. ;)
* timecodes are referenced to the end of video frames, and to the end
of audio chunks, rather than the beginning. This made the code simpler
in 3 places and more complicated in 1 place.
( By the way -- if you're going to work on the player -- take a minute
to see if you can figure out how the audio buffer's read pointer could
"lap" the write pointer. This should never happen, though Isaac seems to
have observed just this. We were stymied, the code looked pretty solid,
to me anyway...)
thanks!
- john