[mythtv] Re:Transcoding pvr-250 files

[Geoffrey Hausheer]

On Thu, 28 Aug 2003 11:25:33 -0400, "Isaac Richards ijr-at-po.cwru.edu
|mythtv/1.0-Allow|" <e6kbhbk35r0t at sneakemail.com> said:
> On Thursday 28 August 2003 09:29 am, Geoffrey Hausheer wrote:
> > Well, either (a) the transcoder cut out the wrong part, (b) I wrote the
> > header incorrectly, or (c) something is wrong with the calculation.  This
> > seems odd.  When you get a chance, can you validate the actual length of
> > the file?  Nothing I did should have caused it to be wrong (that I know
> > of)
> 
> I'd bet it's something to do with the fact that keyframes happen twice as 
> often in the mpeg2 source files as they do in normal .nuv software
> encodes, 
> and you're forcing keyframes at the mpeg2 rate, while the header still
> says 
> it's at the normal .nuv rate.  Make sense?
Ahh, I didn't realize that was the case.  Anyhow, the patch I posted was
just a hack fix.  I think the propper fix should be:
@@ -3214,11 +3217,9 @@
             }
 
             if (forceKeyFrames)
-                writekeyframe = true;
+                nvr->WriteVideo(&frame, true, true);
             else
-                writekeyframe = decoder->isLastFrameKey();
-
-            nvr->WriteVideo(&frame, true, writekeyframe);
+                nvr->WriteVideo(&frame);
         }
 
         if (QDateTime::currentDateTime() > curtime) 


That should fix the force-key thing as well as the time-code thing.

Isaac, feel free to apply that.  Or wait until either (a) someone has
validated it, or (b) I get back on Tuesday, and I'll test it myself.

Thanks,
.Geoff