[mythtv] [patch] Fix crash in MythMusic CD ripper when dealing with invalid files.

Isaac Richards ijr at po.cwru.edu
Thu Dec 4 20:19:38 EST 2003


On Thursday 04 December 2003 06:02 am, J. Donavan Stanley wrote:
> As detailed in this message:
> http://www.gossamer-threads.com/perl/mailarc/gforum.cgi?post=93071;search_s
>tring=mythmusic%20crash;guest=1704927&t=search_engine#93071
>
> In a nutshell when ripCD creates and encoder to rip a track it assumes
> that the file the encoder creates is valid causing it to fail in
> ripTrack if it's not.  This patch adds an isValid function to the
> encoder that returns true if the file handle is non NULL.  RipCD checks
> isValid before calling ripTrack and bugs out of the whole ripping
> process if it gets false back.

Applied this, but added some more checks for out being NULL.

Isaac


More information about the mythtv-dev mailing list