[mythtv] Instant SELECT feedback in Myth menus

Ben Levitt levittben at yahoo.com
Sat Dec 20 04:08:33 EST 2003


I think that one of the remaining usability problems
with myth (espesially on remote frontends) is that
when selecting a menu item is slow (like choosing
Watch Recorded when you have a few hundred shows
recorded), there is no feedback thet you have chosen
the menu item until a few seconds later when the new
screen pops up.

I added a few lines to themedmenu.cpp to make it
visually de-select the menu item imediately when you
choose it.  This way when a new screen is slow to
load, you at least get instant feedback that it got
selected.  

It feels like an improvement to me.  Especially on the
celeron 466.  :]

Isaac, would you prefer some other method of feedback
that doesn't de-select the chosen item?  Everything
else I could think of involved blinking, adding new
theme elements, or using sound.

Ben


__________________________________
Do you Yahoo!?
New Yahoo! Photos - easier uploading and sharing.
http://photos.yahoo.com/
-------------- next part --------------
Index: libs/libmyth/themedmenu.cpp
===================================================================
RCS file: /var/lib/mythcvs/mythtv/libs/libmyth/themedmenu.cpp,v
retrieving revision 1.63
diff -u -r1.63 themedmenu.cpp
--- libs/libmyth/themedmenu.cpp	6 Dec 2003 00:01:44 -0000	1.63
+++ libs/libmyth/themedmenu.cpp	19 Dec 2003 04:12:35 -0000
@@ -1691,7 +1691,10 @@
         }
         else if (action == "SELECT")
         {
-            handleAction(activebutton->action);
+            lastbutton = activebutton;
+            activebutton = NULL;
+            repaint(lastbutton->posRect);
+            handleAction(lastbutton->action);
             lastbutton = NULL;
         }
         else if (action == "ESCAPE")


More information about the mythtv-dev mailing list