[mythtv] [PATCH] Video timebase

[steve at nexusuk.org]

On Mon, 22 Dec 2003, Isaac Richards wrote:

> This looks pretty good, though I'd probably want the buffers in AddAudioData 
> more static, as otherwise, that's a lot of memory allocation/deallocation 
> going on.

That should be trivial to do - I'll have a look into it.  Is there an 
upper limit to the size of the audio samples passed to AddAudioData() 
that I can use for sizing the buffers?

> > Bugs: The audio warper for void NuppelVideoPlayer::AddAudioData(char
> > *buffer, int len, long long timecode) makes a complete mess of the audio.
> > This basically affects PCM audio and probably MPEG2 playback - MP3 audio
> > uses void NuppelVideoPlayer::AddAudioData(short int *lbuffer, short int
> > *rbuffer, int samples, long long timecode) which works fine.
> 
> Are you planning on fixing this?

Yes, when I've worked out what's going on.  I am copying (audio_channels * 
audio_bits / 8) sized chunks of the audio stream which should equate to a 
single sample from all channels, but I must be getting something wrong 
because it sounds terrible.

-- 

 - Steve                                             http://www.nexusuk.org/

     Servatis a periculum, servatis a maleficum - Whisper, Evanescence