[mythtv] Re: MythChannels
ramon.roca at xcombo.com
Thu Jul 31 17:49:43 EDT 2003
I don't think Ben or me were suggesting that it would break anything it is just that it is considered bad coding practise to "overload" a number in such a way that sometimes it means one thing (Hz) and at other times it means another (MHz). Numbers should just mean one thing.
Totally agree, we are not talking about abstract numbers. In this case we take care of tunning information that can be given by consensus in certain ways so we can to parse them, in fact it's quite easy to do in this case, just like pids or many other data. Ben was also afraid of breaking his code, which btw I can't maintain because isn't open source and I haven't the license for doing so, that was just a misunderstanding.
Conversions like this are normally done on interface boundaries (either in the GUI (interface to the user) or external libraries (like libdvbdev)) and avoided in all the rest of the code.
Right, is where is being parsed: just before calling the tune function. Single and safe point to do this. Is where makes more sense in this case. So then anyone can safely use any criteria to write interfaces to load data.
And please don't compare this with driving left or right because the choise between one system or the other is not arbitrary and experience tells us that choosing one or the other makes the difference between code that's easy to maintain because it's meaning is obvious or code that's hard to maintain.
It is if we force rules, or like in this case, metrics, that are particluar/proprietary to this project and distinct from the common used in this context and not needed at all. Also gets easier to maintan if we get synched with the criteria established by the driver, it means, commonly understood by the developers who know about it.
But on the other hand _you_ are the one implementing this and nobody else, so you can decide whatever you want, it's just something you might think about.
That's really the big point. No work will have any sense although compiles and links nicely without warnings if we don't take care of it's usability or we can't get a picture of it, it can have developers but will never have users...Manual channel setup makes sense for Analog TV, but, in common sense not for DVB, we habe been already for months in this situation. We are talking about many channels with many parameters. My 2 cents and what I'm trying to do on this with mythchannels is providing simple paths for exchanging that information from a variety of choices/sources, but that's only part of the history, the other part is the player, parsing the streams etc. Well, I hope that Ben and Kenneth will keep working on this... and you are wellcome if you want, do you have a DVB card?. If I get alone, I tell you that we are dead. Maybe I'm already?
On the other hand, be sure that I'm open on having any open discussion, I do learn a lot of them. Drive a discussion because of having and ownership I don't think that will be contributive at all.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the mythtv-dev