[mythtv] [PATCH] category types (movie idenfication)

[Ben Bucksch]

Isaac Richards wrote:

>Only thing I don't like is:
>
>@@ -176,7 +179,7 @@
>     QString xmltvid = element.attribute("id", "");
>     QStringList split = QStringList::split(" ", xmltvid);
> 
>-    if (!isgist)
>+    if (isNorthAmerica)
>     {
>         chaninfo->xmltvid = split[0];
>         chaninfo->chanstr = split[0];
>
>This.
>
Eh, yes, that got in there accidently from an earlier patch of mine (to 
fix the standard tv_grab_de grabber, the patch I couldn't test fully, 
remember?), sorry. I guessed you'd notice, so I didn't bother to supply 
a new patch.

>Won't this change everyone's xmltvid that's not using tv_grab_na?
>
Yes, intentionally so. I don't think any grabber does the "channum 
callsign" stuff that tv_grab_na does, and it horribly breaks those 
grabbers which use spaces in station names, e.g. "Pro 7" for station Pro 
7, like tv_grab_de does. I don't know what other grabbers do, but I'd 
guess they are much more likely to do what tv_grab_de does than what 
tv_grab_na does, and there's nothing really "breaking", if my assumption 
is wrong, it would just not add channums automatically anymore.

Anyways, it's not supposed to be there in this patch, so just ignore 
this hunk.

>@@ -450,6 +475,17 @@
>         }
>     }
> 
>+    if (pginfo->category == "" && pginfo->catType != "")
>+        pginfo->category == pginfo->catType;
>+
>+    /* Do what MythWeb does and assume that programmes with
>+       star-rating in America are movies. This allows us to
>+       unify app code with grabbers which explicitly deliver that
>+       info. */
>+    if (isNorthAmerica && pginfo->catType == "" &&
>+        pginfo->stars != "" && pginfo->airdate != "")
>+        pginfo->catType == "movie";
>
>Those == are typos, right?
>
Ops, yes, thanks :-).

(hm, I thought the compiler warns me about that. Did I overlook it?)

Ben