[mythtv] [PATCH] New settings module to tune channel by hand andchannel preset hack

Leandro Dardini ldardini at tiscali.it
Thu Jun 5 23:06:20 EDT 2003


----- Original Message ----- 
From: <ramon.roca at xcombo.com>
To: "Development of mythtv" <mythtv-dev at snowman.net>
Sent: Wednesday, June 04, 2003 11:05 AM
Subject: Re: [mythtv] [PATCH] New settings module to tune channel by hand
andchannel preset hack


> Leandro,
>
> This patch looks to me very nice, very usefull for those countries where
> there is no channel info at the xmltv listings or channel icons, and can
> provide an easier way to introduce the channels than
> mythfilldatabase --manual, it's also clean since those who have that info
at
> the xmltv will can simply skip it ans even simplifies to add new inputs
such
> as AV etc.

Thank you

> It only breaks Ben's "channel preset hack", since doesn't take care of the
> channum_real column.

I don't like Ben "channel preset hack". I think there is no need to add
another column and I think it is a better way to use the chanid column.
Remember that chanid is already used as sort column, so it is already
exposed to the user. As I have some spare time, I try to submit a patch for
this...

> Maybe it's time to think for a definitive solution on this controversy?

Yeah... I am tired to up&down twenty channel. I have to admin I am starting
to use direct frequency, but I have some channel outside of the UHF
frequency.
I don't like to work for nothing... I hate to have "personal" patch (like
the manual recording one) so I think only Isaac can point out the right
direction.... or maybe he has already pointed out and I don't see it?

>
> Since it will affect to the database, maybe that's something for 0.10.
> However after thinking on this that could be as simple as:
>
> -add a "chanfreq" column, that defaults to current channum value, and
> equivalent to Ben's channum_real (I do prefer to call it chanfreq since
> describes better its content). Populate both columns channid and chanfreq
> during mythfilldatabase first setup to the same value, so that will be
> transparent to the current US users.
> -use Ben's way to change the channel using chanfreq.
> -allow, with a new setting at the setup, to choose between current
behaviour
> for US user (default) or use "preset" equivalencies instead of channum. If
> the user selñects this way, then the channum column could be updated to
> current chanid primary key, therefore, a first default preset will be done
> using chanid. Now, non-us numbers will have a simple sequence starting by
1
> that preset tuning to each channel.
> -then, with Leandro's manual tuning, the user will be able to change the
> preset numbers, the only thing that must bu changed for doing so is
instead
> of editing chanid column, edit channum, and of course, change the channum
to
> chanfreq.

As stated before, all is more simple if we use the chanid as the preset
colum. It needs a little modification to the code and no modification to the
database. Isaac, what do you think?

>
> Doesn't sounds this something that once has been done could make happy
> everyone and therefore applied to CVS?

Our heaven... the CVS :)

Leandro

>
> Ramon.
>
> _______________________________________________
> mythtv-dev mailing list
> mythtv-dev at snowman.net
> http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-dev



More information about the mythtv-dev mailing list