[mythtv] First patch for runtime configurable keybindings
ijr at po.cwru.edu
Mon Mar 3 09:50:10 EST 2003
On Monday 03 March 2003 02:31 am, Erik Arendse wrote:
> Hi Isaac & All,
> Finally some results from an idea started many weeks ago :-)
> This patch introduces the basics for runtime configurable keybindings. I
> must make some remarks here, and are curious for any testresults:
> 1) I revamped the output class into a QWidget-aware thing. I blew xinerama
> support for now, but AFAIK the QT-lib is xinerama-aware, so maybe it still
> works. Just tell me what happens, I don't have xinerama working here even
> though I run a G400DH. If it is broken perhaps somebody else could pick up
> some original pieces and re-insert them, or just complain and I'll try to
> install xinerama. I'm rather certain PIP isn't working as well, but that
> should be trivial if somebody could tell me where it breaks.
Please don't rename the XvVideoOutput class, and don't unnecessarily move
stuff into the XvData structure, as most of the changes in the XvVideoOutput
class look totally unnecessary. If someone wants to write other output
methods, the way to do that would be to write a generic abstract video output
class and make XvVideoOutput and the new method extend off of that, rather
than modifying XvVideoOutput to do that. Check out the MythDialog
constructor on how to deal with xinerama properly.
NuppelVideoPlayer::ReConfigure() is poorly named. You're not reconfiguring
anything in that object, you're reconfiguring the display.
> 2) No setup module is present yet, if you look in the source you can see
> how the settings are called in the database (Key_%1_%2 where %1=context and
> %2=function), this patch should be totally transparent as the default
> keybindings are equal to Isaacs.
> 3) Only the TV and EPG module are patched, to show both normal keycode-test
> bindings and QT-accelarator support, if this is accepted the rest will
You can go ahead and remove the old code, instead of just commenting it out.
I don't blindly apply patches, I can see what's changed.
> 4) I'd like to have this framework in CVS before adding a setup module and
> adding keysupport to more
> modules, I get tired of manually solving all update-conflicts ;-(
> 5) There is still some debug-output, I will remove it in a near future
Don't submit stuff with debug output =)
I'd almost prefer for the keymap to live in the context, instead of inside
each window object.
More information about the mythtv-dev