[mythtv] [PATCH] New filter API, first patch against CVS.

Isaac Richards ijr at po.cwru.edu
Tue Nov 4 22:54:09 EST 2003


On Saturday 01 November 2003 03:30 pm, Andrew Mahone wrote:
> On Saturday 01 November 2003 11:21, Isaac Richards wrote:
> > Couple minor changes which I'd like to see before applying this, all
> > stylistic:
> >
> > - 80 character lines
> > - FilterChain.h/FilterManager.cpp/.h renamed to lowercase.
> > - Stuff like
> >      if( Filter->cleanup )
> >    changed to
> >      if (Filter->cleanup)
> >
> > Thanks,
> > Isaac
>
> Indent to the rescue!  All done, also removed extern "C" {} around filter.h
> includes.  Been a while since I did much C/C++, but this is not needed now
> that filter.h has no function prototypes, right?  Rebuilt to make sure I
> didn't miss any Filter(Manager|Chain).h includes, looks good.

Thanks for making the changes -- I've just finished applying this to CVS.  I 
did get rid of filterchain.h, as it really doesn't hurt to just have the 
class at the top of filtermanager.h..  Also cleaned up some of the includes, 
etc..

I also just applied your recent opts to the denoise3d plugin.

Isaac


More information about the mythtv-dev mailing list