[mythtv] [PATCH] New filter API, first patch against CVS.

[Andrew Mahone]

On Fri, 7 Nov 2003 03:04:39 -0500, "Isaac Richards" <ijr at po.cwru.edu>
said:
> Heh.  Seems the disappearing OSD bug some people are reporting is due
> to the new filter stuff..  maybe, at least.  Been trying to track it
> down with Thor a bit, with no real success.  It seems to go away with
> deinterlacing turned off, or with the filters otherwise deactivated.
>
> Also, I've fixed up some stuff in NVR.cpp that wasn't dealing with the
> possibility of different video sizes after the filters, but NVP.cpp
> isn't handling that at all properly, from what I can tell.
>
> Isaac

I only said more readable, not more correct, heh...  I'm looking at the
changes now, I had figured the videoOutput would need to init with the
post-filter size, as this is the size actually being displayed.  That
shouldn't be the problem anyways, because all existing filters should
leave width and height the same.  And yes, I've seen a little flakiness
w/ OSD for a little bit now, too...  I didn't make the connection, but it
could easily be something I did.

Also looking at the NVR stuff...  my understanding here was that
StartRecording was only called when recording from a capture card (as
opposed to transcoding).  I was setting inpixfmt to FMT_NONE there to
allow the filter chain to select the capture format.  Forcing it to
FMT_YV12 shouldn't be necessary anyways, as it defaults to FMT_YV12 in
NVR's constructor.  Perhaps filter-selected capture format would be
cleaner if tv_rec used SetOption to change inpixfmt before starting
recording, and it were left alone in NVR::StartRecording?
-- 
  Andrew Mahone
  andrewmahone AT eml DOT cc

-- 
http://www.fastmail.fm - Email service worth paying for. Try it for free