[mythtv] [PATCH] Use frame number as position map key

Doug Larrick doug at ties.org
Sun Nov 30 18:20:33 EST 2003


On 11/30/03 18:00:11, Isaac Richards wrote:

> Looking at this more, I don't this will work properly.
> 
> - The database is only updated every 15 seconds or so (so as to not  
> be hitting the db every half second), so grabbing data from an in- 
> progress recording will fail.  It should probably query the backend  
> with something like the 'nvr->FillPositionMap' stuff if it can, and  
> then fall back to the database and then fall back to the old stream  
> parsing code you removed =) (see next)

The behavior I see is that you simply can't fast forward any closer to  
real time than 15 seconds behind.  My recollection is that for live TV,  
we don't have a positionmap at all anyway, and fall back to alternate  
methods.  The code you're questioning only gets involved when watching  
an in-progress recording.  But I'll take another look.

> - The old code wasn't manufacturing data, it was parsing the stream
> (without decoding) to get the proper offsets for what it skipped  
> over.

The way I read the old code in DoFastForward, it may have been parsing  
the stream for position, but it was not looking for keyframes, just  
assuming they occurred every 'keyframedist' frames.  I could be wrong  
though.

-Doug
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20031130/835b8fa5/attachment.pgp


More information about the mythtv-dev mailing list