[mythtv] Patch: segfault caused by mythcommflag

Edward Wildgoose edward.wildgoose at frmhedge.com
Sat Oct 4 17:52:04 EDT 2003


Mythcommflag seems to use NuppelVideoPlayer to decode the stream, however,
when the aspect ratio is changed then the ReinitVideo is called, which in
tern calls OSD::Reinit.  However, OSD was never setup -> segfault

Following trivial patch seems to fix this:

Index: libs/libmythtv/NuppelVideoPlayer.cpp
===================================================================
RCS file: /var/lib/mythcvs/mythtv/libs/libmythtv/NuppelVideoPlayer.cpp,v
retrieving revision 1.285
diff -u -r1.285 NuppelVideoPlayer.cpp
--- libs/libmythtv/NuppelVideoPlayer.cpp        26 Sep 2003 21:32:19
-0000      1.285
+++ libs/libmythtv/NuppelVideoPlayer.cpp        4 Oct 2003 15:36:50 -0000
@@ -347,7 +347,8 @@

     videoOutput->GetDrawSize(dispx, dispy, dispw, disph);

-    osd->Reinit(video_width, video_height, frame_interval,
+    if (osd)
+        osd->Reinit(video_width, video_height, frame_interval,
                 dispx, dispy, dispw, disph);

     ClearAfterSeek();



More information about the mythtv-dev mailing list