[mythtv] [PATCH] Picture Adjust

[Ben Levitt]

Here's my updated Picture Adjust patch

It seems to work well for Xv.  It doesn't change
anything for non-Xv (just X).  It might work for XvMC
decoders, and it's not implemented for the ivtv
decoder nor for the via decoder.  :)

Can someone with XvMC test it out?

Isaac, if there are any other changes you'd like me to
make please let me know!

Thanks,

Ben


--- Isaac Richards <ijr at po.cwru.edu> wrote:
> On Wednesday 08 October 2003 01:12 am, Ben Levitt
> wrote:
> > This patch lets you adjust the global playback
> > settings for brightness, contrast, saturation
> > ("colour") :) , and hue.
> 
> Heh, I didn't add the color controls stuff,
> obviously =)
> 
> > 1) I only implemented actually changing these
> settings
> > when using Xv.  If anyone knows how to do this
> using
> > the ivtv out or XvMC, please let me know! 
> Viaslice?
> 
> xvmc _should_ work with the same code as xv output. 
> I don't think the ivtv or 
> via stuff supports that, but I could be wrong.
> 
> > 3) Should I change the OSD code to take a callback
> > function to use when the OSD is done fading out? 
> This
> > seems like it would be the clean way to know when
> the
> > OSD has faded out.  This would also be useful for
> > another patch I want to fix up...
> 
> signal/slot if possible.
> 
> > 4) Isaac, is this patch (or something like it)
> > something you'd like to commit after it gets
> cleaned
> > up?  (I think I got all the white space nice and
> > clean!  :] )
> 
> Yeah, it looks mostly fine, except the use of
> av_gettime() and I don't really 
> like the way the stuff in Key_Right/Left works, but
> I suppose that'd get 
> cleaned up by using a better mechanism to know when
> the OSD is gone..   It'd 
> also be better if I had ever gotten around to making
> a better menu for the 
> OSD during playback, so there wouldn't have to be
> yet another keybinding...
> 
> Isaac
> _______________________________________________
> mythtv-dev mailing list
> mythtv-dev at mythtv.org
> http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

__________________________________
Do you Yahoo!?
The New Yahoo! Shopping - with improved product search
http://shopping.yahoo.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pictureAdjust2.patch
Type: application/octet-stream
Size: 27941 bytes
Desc: pictureAdjust2.patch
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20031009/e19754ea/pictureAdjust2-0001.obj