[mythtv] [PATCH] MythGame mamehandler fixes
dan at milkcarton.com
Wed Oct 29 04:12:16 EST 2003
> Isaac, I think you should take another look at this. I'm pretty sure
> DanM's patch is incorrect. His post indicates that he intended his
> patch to keep makecmd_line from using uninitialized values, but in
> fact it is not possible for any of these values to be uninitialized.
> What his patch actually does is keep makecmd_line from using
> initialized values.
Morgan, I can assure you that it does indeed (at least) for me keep it
from using uninitialized values.
> The values are always initialized because: 1) gamedb/metadata.sql
> creates an initial mamesettings entry in the database for romname
> "default" with default values for all of these settings. 2) The
Thats never happened for me. My personal experience and I've verified
this by looking at the DB is it only creates those values in the DB if
you've made changes to the games settings IIRC.
> MameHandler constructor calls SetDefaultSettings which loads the
> mamesettings for romname "default" into defaultSettings. 3)
> makecmd_line calls SetGameSettings to get the game settings it uses
> to construct the command line. 4) the first line of SetGameSettings
> assigns defaultSettings to game_settings thus initializing all of its
More information about the mythtv-dev