[mythtv] Stop recording patch and some small fixes
ou401cru02 at sneakemail.com
Thu Sep 18 08:15:32 EDT 2003
On Thu, 18 Sep 2003 11:06:30 +0200, "Tako Schotanus
<hd1zhicfeg0t at sneakemail.com> said:
> Maybe the code could be merged somehow (haven't looked at your code yet
> though) because the whole point of the dialog I made was to have
> complete control over the number of labels and buttons that get
> displayed. This to be able to show both the dialogs that where already
> there and the new dialog that I needed to make.
> But it would probably be extremely easy to make your code use my code,
> because yours is an even simpler case than mine. Making a 2 button
> dialog with a title and a message would take very little code.
Looking at what you've got, I think yours has a different philosophy than
mine. I don't want to have callbacks for each button. I just want a
modal dialog that returns the number of the button that was pressed.
Adding extra buttons would be trivial (just pass in a QStringList).
Adding more messages is more tricky, since it requires knowing how to
place them. Plus, I have no use for a programInfo structure in my
dialog, and I don't think it belongs in a general-purpose dialog.
Basically, I think what you've got is way overkill. I don't really care
which way you go, but if you are going to keep it complex, with callbacks
and initialization routines, then just make another dialog class, and
leave me my simple Myth2Button class.
More information about the mythtv-dev