[mythtv] [PATCH] DiSEqC 1.2/1.3 HH Motor Support + DiSEqC 1.x Switches

Kenneth Aafl°y ke-aa at frisurf.no
Thu Apr 1 03:02:34 EST 2004


On Thursday 01 April 2004 08:39, Taylor Jacob wrote:
> I posted this a few days ago without the [PATCH] topic and -u option when
> generating my diffs.  Most of the functions for motor control will need to
> be called from the Card Verification Wizard.

Are you going to take care of this too?

> Notes for this patch:
>
> DiSEqC 1.x switches work.
> DiSEqC HH Motors now work with the goto stored position xx command. The
> diseqc_type must be set to 6, and the stored position of the sat set in
> diseqc_port (both fields in dvb_sat).

I guess a modification to the channel editor should be made also; 
videosource.h:594.

> I am going to need to make some changes to the DB for the dvb_sat table to
> change the Position to be a float/double to support USALS/DiSEqC 1.3
> Extentions (Set Motor to angle x.x degrees), and add a column that will
> store the DiSEqC motor saved position number.  This is required because if
> you use a switch in combintion with a motor you will be required to have 2
> "positions" one being the switch, and the other the motor saved position.

> Should I just make the changes in dbcheck.cpp, and send them here, or do
> these changes need to be approved before being applied?

Please do!

Please follow the existing coding style; new-line after if's, lines wrap at 
<80, and so on. Apart from that I would have applied it (if I had access).

Thanks for writing this!

-- 

Kenneth
ke-aa at frisurf.no


More information about the mythtv-dev mailing list